The Economic Benefit of Refactoring

(martinfowler.com)

37 points | by javaeeeee 1 hour ago

11 comments

  • firasd 9 minutes ago
    I think this is one of those things where a human in the loop is indispensable

    An agentic refactoring pass does make sense cause one LLM reviewing work can spot things the ‘generator’ LLM missed while focused on the initial task output

    But can the reviewer agent ever actually have in mind what this project actually is? And how the code all comes together to do the work involved? In other words what parts of the code are redundant or can be made more elegant

    Asking coding agents to refactor your codebase is maybe like asking trauma surgeons to increase your exercise capacity. The agents are gonna need a really holistic POV to do this properly

    I guess part of my point is just that splitting files to make them smaller is only refactoring in a superficial sense without having a theory of what code belongs together and what can be extracted into utility functions etc

  • BenoitEssiambre 3 minutes ago
    The benefits go beyond reducing token consumption. Compact contexts also foster better reasoning, enable intelligence across more layers if you can load them in a single context, and writing software to enable this, results in more correct software, software that _generalizes_, that has higher probability of being correct not just for tested cases, but for the interpolations and extrapolations of these cases.

    Refactoring towards good abstractions is more powerful than people realize. There's information theoretic bayesian math to back this up.

    It's a bit of a divine coincidence that software that is more economically and energy efficient to process and run tends to also be more correct.

    It's all about reducing the entropy of your code. https://benoitessiambre.com/entropy.html

  • pmg101 31 minutes ago
    It's very interesting to have some data on this.

    It matches my experience which is that LLMs greatly benefit from well factored code, but are not particularly adept at creating such code.

    Much like most human developers I suppose!

  • vehemenz 3 minutes ago
    Opus/Fable 5 (or really, any thinking model) do a better job of refactoring than Sonnet would. I think the takeaways are still valid, just not as valid when using a more expensive model at a higher effort level.
  • danbruc 12 minutes ago
    Interesting that the amount of code essentially remained unchanged. In my experience it is not unusual that refactoring messy code cuts the number of lines in half.
    • stingraycharles 10 minutes ago
      It can go both ways. Lines of code is a terrible metric for pretty much any goal that refactorings are meant to tackle.
      • NichoPaolucci 2 minutes ago
        I don’t know. LOC to me is indispensable for certain refactoring goals in my opinion.

        Taking a component and turning it from 7K lines to 3K lines and maintaining functionality obviously means there’s less complexity introduced, less to go wrong now, and less overhead to modify in the future.

        Sure it can go the other way, the component needs to support something it might need, we need to adjust larger patterns, this function needs to be refactored into something more robust.

        But lines of code is a pretty decent metric of success for “trimming down and cleaning up” style refactoring, to me at least. It’s not everything of course, but it’s definitely an indicator.

  • sltr 32 minutes ago
    the punchline: "Refactoring reduces token consumption"

    I appreciate the effort to quantify the benefit rather than pontificate. It's worth mentioning Martin Fowler wrote a whole book on refactoring [1], in which he states, "to refactor, the essential precondition is [...] solid tests", which I think is the real benefit here, AI or not. Good tests protect against regressions, whether human or robot. They also help encode the spec, which humans and robots can read.

    [1] https://www.oreilly.com/library/view/refactoring-improving-t...

    • pmg101 29 minutes ago
      (Just to note that although the article is on martinfowler.com Martin is not the author. It's attributed to Thoughtworks CTO Giles Edwards-Alexander.)
      • sltr 22 minutes ago
        Thanks for catching that. Updated my post
  • imoverclocked 35 minutes ago
    It’s interesting that cyclomatic complexity or cognitive complexity scales with token usage. A codebase that enforces upper bounds on one of these two also (potentially) helps AI agents stay efficient.
  • theturtletalks 11 minutes ago
    Make it work, make it right, make it fast, in that order

    Make it right is the refactoring

  • vaylian 32 minutes ago
    Interesting take-away:

    > Claude is unable to look at code, look at refactorings in general and work out which are suitable to apply: a human needs to actively guide it.

    Claude is happy to produce a very large Rust file. But you need human guidance to make it smaller.

    • vehemenz 1 minute ago
      "I would have written a shorter letter but did not have the time"
  • paxys 12 minutes ago
    I have been enforcing this myself through AGENTS files and other explicit instructions. What’s crazy is that none of the existing coding harnesses include such instructions by default. Two lines in Claude Code and Codex and the entire world would be writing better, more efficient code. Makes me believe in the conspiracy that these companies want more verbose code and longer files because it directly results in higher token usage.
  • defrim 38 minutes ago
    Being a bit cheeky here -- the amount of comments on this post is a telltale sign of how common / desirable refactoring is for the majority of developers (xD). It isn't our fault though, maybe if those pesky managers read this article then they would understand..
    • sltr 32 minutes ago
      It's been on HN for 45 minutes. It's before 9am on the west coast