11 comments

  • dsego 2 hours ago
    Sorry for being pedantic, but the first example could be rewritten to extract the pattern into a higher level hook, eg useNotifications. One way to simplify components before reaching for store libraries. The reusable hook now contains all the state and effects and logic, and the component is more tidy.

        function Dashboard() {
          const { user } = useAuth();
          const {loading, error, notifications, undreadCount, markAsRead} = useNotifications(user);
    
          if (loading) return <Skeleton />;
          if (error) return <p>Failed to load: {error}</p>;
    
          return (
            <div>
              <h1>Dashboard ({unreadCount} unread)</h1>
              <StatsCards stats={stats} />
              <NotificationList items={notifications} onRead={markAsRead} />
            </div>
          );
        }
    • altbdoor 4 minutes ago
      Working with multiple teams in a large project, hooks can be a nightmare to maintain.

      I see 7x layers deep of hooks, with no test cases to support them. Some of the side effects are not properly tested, and mocks that abstract away the whole implementation means the test case only works for certain scenarios.

      FWIW this scenario might be an outlier in large projects, considering how some developers prefer to "just wrap the hook in another hook, and not worry about its internals".

    • whizzter 2 hours ago
      Far cleaner, how is testability though?
      • SketchySeaBeast 2 hours ago
        Very easy - mock the useNotifications and you can easily see all the behaviour by changing three properties.
  • lateforwork 1 hour ago
    You can use React in an MVC framework, with React used to implement the 'V' in MVC. You can use class components, and the code becomes extremely simple. Business logic is moved to 'M' layer (models) and the 'C' layer (controllers) coordinates everything. No hooks or other messy stuff needed.

    In fact, React was originally designed to be used this way (as the V in MVC)!

    See https://github.com/Rajeev-K/mvc-router

    • bobthepanda 43 minutes ago
      You can do this pretty simply with hooks and reducers, where the reducer/dispatch are the model/controller.

      Class components have their own pitfalls when you start messing around with componentDidUpdate, which was part of the motivation behind functional components IIRC.

      • lateforwork 37 minutes ago
        Not everyone likes hooks. Class components may have issues, but if hooks are the solution I'll stay with class components, thank you very much!
  • hungryhobbit 2 hours ago
    Javascript and classes go together like toothpaste and orange juice. All good JS programmers I know essentially pretend that classes don't exist in the language (or if they use them, they only do so rarely, for very niche cases).

    JS does not have classical OOP built in! It has Brandon Eich's prototypal inheritance system (which has some key differences), along with a 2015 addition to the language to pretend it has OOP (but really that's just lipstick on the underlying prototypal pig).

    If you use classes in JS, you're bound to be disappointed at some point when they don't behave like classical OOP. Most devs accept that and use more functional approaches (like factory functions) instead of OOP.

    • spankalee 2 hours ago
      Counterpoint: classes are a great way to bundle state and logic - which is exactly what UI components are - and components models should use classes more, not less.

      React's "functional" components are simply poor approximations of classes. Instead of easy to read and reason about class fields, you put state in useState() function classes that are effectively named by their appearance order in source and who's current state you can't introspect with dev tools!

      The component function mixes one-time setup (which should be a class constructor) with repeated render calls (which should be a method), so those of course have to be separated by putting the one-time work inside of a closure inside of the repeated should-have-been-a-callback function. Event listeners and other callbacks are another huge mess. Don't forget useMemo() or useCallback() (but which?).

      It's actually quite mad.

      And the differences between classical and prototypal inheritance basically don't even pop up under normal class usage in JS: just use class fields, don't mess with the prototype chain, and don't dynamically add or delete properties - all things that are how classical inheritance works - and things just work like you expect.

      • Weebs 1 hour ago
        They're modeling reactivity, not classes. It's a well established pattern in functional programming

        The one time setup mixed with repeated render calls is odd, but it's a design decision they made. It reduces boiler plate, though I don't necessarily agree with it because it is a leaky abstraction

    • apatheticonion 1 hour ago
      I have noticed that inheritance is largely ignored by experienced developers but it's a hard argument to make that "all good JS programmers do this".

      Classes are invaluable and are an extremely efficient and ergonomic way to manage state in GUI applications.

      That said, avoiding classes was published in some blog post at some point and the JS hype machine went crazy with FP. As a consequence, I have yet to observe a maintainable React codebase. Good looking and performant React applications are even fewer and farther between.

      Personally, writing idiomatic React has me focus too much on render cycles that I think less about how the application looks & feels. Appropriate abstractions become more difficult to conceptualize and any non-trivial application ends up a 5mb bundle with no multi-threading or optimizations. This is also what I have observed "the best JS devs" do in the wild.

      • benatkin 50 minutes ago
        Inheritance is used here:

        https://github.com/thalesfp/snapstate/blob/ba8a8d7ce25d6a4ef...

        I'm not sure if it would support inheriting from a custom store very well. It might get tricky with the templating. But the author of this seems to have done a good job of not ignoring inheritance.

        • apatheticonion 17 minutes ago
          Personally this library isn't to my taste - but I successfully use classes (without inheritance) along with reactivity primitives to create beautiful, tiny and high performance React applications
    • hackingonempty 1 hour ago
      > Javascript and classes go together like toothpaste and orange juice.

      Even HN has been taken over by shills from Big Mint.

    • lateforwork 2 hours ago
      Encapsulation, inheritance and polymorphism all work fine with JavaScript classes. OOP works just fine.

      What doesn't work in JavaScript is functional programming.

    • aylmao 1 hour ago
      I think the biggest issue with classes is subclassing, it looks like a good feature to have, but ends up being a problem.

      If one avoids subclassing, I think classes can be quite useful as a tool to organize code and to "name" structures. In terms of performance, they offer some good optimizations (hidden class, optimized instantiation), not to mention using the memory profiler when all your objects are just instances of "Object" can be a huge pain.

    • epgui 2 hours ago
      For clarity, what do you call "classical OOP"?

      (disclaimer: FP all the way, regardless)

      • hungryhobbit 2 hours ago
        Essentially `new Foo()`, where `Foo` can be a subclass of `Bar` that inherits properties in the same way we all learned in our Java (or whatever actual OOP) language.

        JavaScript gives you a class syntax that lets you make classes and extend them from each other, and for the most part they will work the same way as a class from a language like Java ... but some things won't.

        You can either become an expert on prototype chains, and how JS actually implements OOP (differently from Java) ... or you can just write factory functions instead of classes.

        • epgui 52 minutes ago
          Don’t most OO languages have similar differences? My understanding is that even Java is quite different from, say, Smalltalk (which arguably is “more OG”).
        • kretaceous 2 hours ago
          Can you give examples of how they are different? I've only done OOP in JS so I'm not aware of what I'm missing or what's supposed to be different.
    • benatkin 53 minutes ago
      I went through the code, and it is roughly equivalent to doing it without classes. The nesting level in the example isn't deep - everything seems to be beneath a SnapStore or a SnapFormStore, without inheriting from user defined classes. I think the use of classes is fine, and the way that it's introduced in the blog post is good, it says "plain TypeScript classes". It is used as a means for ergonomically writing and understanding the code more than it is for setting up invariants or complex polymorphism.
    • molszanski 1 hour ago
      Potato potato. Js classes are just closure sugar. So what?

      Syntax makes sense and improves readability in business logic. Readability is good

  • igor47 3 hours ago
    All the examples are fetching data from a server, and in such cases I think tanstack query already does all the hard part. I feel like people under-use react query and put too much state in their FE. This might be relevant if your app has some really complicated interactions, but for most apps they should really be a function of server, not client, state. Of course this exact reasoning is why I moved off react altogether and now use htmx in most of my projects
    • dsego 2 hours ago
      It's not just react query, you can make a quick useFetch and useMutation hooks (or claude can), it's not that complex. If you don't need more advanced features (eg caching), you can easily cut down on 3rd party dependencies.

          import { useState, useEffect } from "react";
      
          function useFetch(url) {
            const [data, setData] = useState(null);
            const [loading, setLoading] = useState(true);
            const [error, setError] = useState(null);
      
            useEffect(() => {
              const controller = new AbortController();
      
              fetch(url, { signal: controller.signal })
                .then((res) => res.json())
                .then((json) => {
                  console.log("Data:", json);
                  setData(json);
                })
                .catch((err) => {
                  if (err.name !== "AbortError") {
                    console.error("Fetch error:", err);
                    setError(err);
                  }
                })
                .finally(() => setLoading(false));
      
              return () => controller.abort();
            }, [url]);
      
            return { data, loading, error };
          }
      
      
      
      
      
      
      
          function App() {
            const { data, loading, error } = useFetch("https://jsonplaceholder.typicode.com/todos/1");
      
            if (loading) return <p>Loading...</p>;
            if (error) return <p>Error</p>;
            return <pre>{JSON.stringify(data, null, 2)}</pre>;
          }
  • oDot 2 hours ago
    The problems OP tries to address are unfortunately a deep design flaw in mainstream frameworks like React and Vue. This is due to 2 properties they have:

    1. They marry view hierarchy to state hierarchy

    2. They make it very ergonomic to put state in components

    I've been through this endless times. There are significant ways to reduce this friction, but in the end there's a tight ceiling.

    This is why this kind of work feels like chasing a moving target. You always end up ruining something inherent to the framework in a pursuit to avoid the tons of footguns it's susceptible to.

    It's also why I moved to Gleam and Lustre (elm architecture) and bid those PITAs farewell

    • svieira 52 minutes ago
      Is this because Elm forces you to separate the model computations from the view computations, which then lets you compose the model shape in one place and the view shape in the other, or some other property of the framework that I'm not aware of?
  • apatheticonion 1 hour ago
  • jemmyw 2 hours ago
    We have a similar style of react state manager that we use at Aha! https://github.com/aha-app/mvc

    I think the intent is very similar even though there are some structural differences: move the state and state logic out of the view to classes.

  • mjfisher 3 hours ago
    Just to sanity-check my reading of this:

    - Zustand exposes itself as a hook.

    - MobX does that observer-wrapper thing

    - Snapstate instead has an explicit writing step (`scoped()`) at the bottom of a component

    If so, I really quite like that. Kudos!

  • fiddeert 1 hour ago
    Still waiting for "I was tired of AI titles using the format 'I was tired of x, so I built y', so I built ..."
  • confidantlake 1 hour ago
    Seems like a solution in search of a problem.