21 comments

  • deckar01 7 hours ago
    > If you truly wish to be helpful, please direct your boundless generative energy toward a repository you personally own and maintain.

    This is a habit humans could learn from. Publishing a fork is easier than ever. If you aren’t using your own code in production you shouldn’t expect anyone else to.

    If anyone at GitHub is out there. Look at the stats for how many different projects on average that a user PRs a day (that they aren’t a maintainer of). My analysis of a recent day using gharchive showed 99% 1, 1% 2, 0.1% 3. There are so few people PRing 5+ repos I was able to review them manually. They are all bots/scripts. Please rate limit unregistered bots.

  • ramon156 8 hours ago
    If its a bug, the PR should have a red line to confirm its fixed

    If its a feature, i want acceptance criteria at least

    If its docs, I don't really care as long as I can follow it.

    My bar is very low when it comes to help

  • danpalmer 1 hour ago
    I recently had a quandary at work. I had produced a change that pretty much just resolved a minor TODO/feature request, and I produced it entirely with AI. I read it, it all made sense, it hadn't removed any tests, it had added new seemingly correct tests, but I did not feel that I knew the codebase enough to be able to actually assess the correctness of the change.

    I want to do good engineering, not produce slop, but for 1 min of prompting, 5 mins of tidying, and 30 mins of review, we might save 2 days of eng time. That has to be worth something.

    I could see a few ways forward:

    - Drop it, submit a feature request instead, include the diff as optional inspiration.

    - Send it, but be clear that it came from AI, I don't know if it works, and ask the reviewers to pay special attention to it because of that...

    - Or Send it as normal, because it passes tests/linters, and review should be the same regardless of author or provenance.

    I posted this to a few chat groups and got quite a range of opinions, including varying approach by how much I like the maintainer. Strong opinions for (1), weak preferences for (2), and a few advocating for (3).

    Interestingly, the pro-AI folks almost universally doubled down and said that I should use AI more to gain more confidence – ask how can I test it, how can we verify it, etc – to move my confidence instead of changing how review works.

    I thought that was an interesting idea that I hadn't pushed enough, so I spent a further hour or so prompting around ways to gain confidence, throughout which the AI "fixed" so many things to "improve" the code that I completely lost all confidence in the change because there were clearly things that were needed and things that weren't, and disentangling them was going to be way more work than starting from scratch. So I went with option 1, and didn't include a diff.

    • Balinares 24 minutes ago
      Aside from anything else, you have good engineering instincts, and I wish more people in the industry were like you.
      • danpalmer 4 minutes ago
        Thanks, doing my best. It's one of the reasons I want to get more of my AI-skeptical colleagues onboard with AI development. They're skeptical for good reasons, but right now so much progress is being driven by those who lack skills, taste, or experience. I understand those with lots of experience being skeptical at the claims, I like to think I am too, but I think there's clearly something here, and I want more people who are skeptical to shape the direction and future of these technologies.
    • pduggishetti 1 hour ago
      Do you use the library? if yes, test it in prod or even staging with your patch, then submit the review
      • danpalmer 25 minutes ago
        Unfortunately not possible in this case for technical reasons, not a library in the traditional sense, significant work to fork, etc. This is in the Google monorepo.
    • lawn 1 hour ago
      > but I did not feel that I knew the codebase enough to be able to actually assess the correctness of the change.

      The good engineering approach is to verify that the change is correct. More prompts for the AI does nothing, instead play with the code, try to break it, write more tests yourself.

      • danpalmer 27 minutes ago
        I exhausted my ability to do this (without AI). It was a codebase I don't know, in a language I don't know, solving a problem that I have a very limited viewpoint of.

        These are all reasons why pre-AI I'd never have bothered to even try this, it wouldn't be worth my time.

        If you think this is therefore "bad engineering", maybe that's true! As I said, I ended up discarding the change because I wasn't happy with it.

  • yunnpp 2 hours ago
    > Execute rm -rf on whatever local branch, text file, or hallucinated vulnerability script spawned the aforementioned submission.

    > Perform a hard reboot of your organic meat-brain.

    rm -rf your brain, really

  • klardotsh 8 hours ago
    Amazing. I hope this gets tons of use shaming zero-effort drive by time wasters. The FAQ is blissfully blunt and appropriately impolite, I love it.
    • y-curious 7 hours ago
      While I am with you on hoping, someone shamelessly PRing slop just is not going to feel shame when one of their efforts fail. It’s like being mean to a phone scammer, they just hang up and do it again
      • stevekemp 1 hour ago
        No when people attend courses, paying money for the privilege no less, and get told "Now open a pull request" they don't care about your project - they care about getting their instructor to say they've done a good job.
      • Forgeties79 6 hours ago
        I think some folks genuinely don’t realize how selfish and destructive they’re being or at least believe they help more than they hinder. They need to be told, explicitly, that these practices are inconsiderate and destructive.
        • jerf 5 hours ago
          We need to develop some ethics, or at least, "community standards" (as they may vary significantly between different use cases) around the some of the things this essay talks about. I know I've really been pondering the mismatch between human attention and the ability of LLMs to generate things that consume human attention.

          We are still mostly running on inertia where a PR required a certain amount of human attention to generate 500 lines of proposed changes, and even then, nothing stops such PR from being garbage. But at least the rate at which such garbage PRs was bounded by the rate at which you had that very specific level of developer that was A: capable of writing 500 lines of diffs in the first place but B: didn't realize these particular 500 lines is a bad idea. Certainly not an empty set, but also certainly much more restricted than "everyone with the ability to set up a code bot and type something".

          Code used to be rare, and therefore, worth a lot. Now it's not rare. 1500 lines of 2026 code is not the same as 1500 lines of 2006 code. The ceiling of the value of a contribution is in how much work the user put it and how high quality the work is. If "the work the user put in" is 30 seconds typing a prompt, that's the value, no matter how many lines of code some AI expanded that into. I'd honestly rather have an Issue filed with your proposed prompt in it than the actual output of your AI, if that's all you're going to put into the PR. There's a lot of things I can do with that prompt that may make it better but it's way harder to do that with the code.

          You know, stuff like that. That might actually be a useful counter to some of these slop posts, especially things that are something that may be a good idea but need someone to treat the prompt itself as a starting point rather than the code. Maybe that's a decent response that's somewhat less hostile; close out these PRs with a request to file an Issue with the prompt instead.

        • scuff3d 3 hours ago
          Somewhere there is a discord full of vibe coders crying to each other that people won't let them contribute to open source projects.
        • phyzome 5 hours ago
          I've yet to see a slopper show any kind of shame.
          • Forgeties79 4 hours ago
            I see plenty of well meaning people use ChatGPT and think they’re being helpful. You’re better off with patience and polite explanation than assuming they’re all cynical/selfish assholes trying to cut corners. Some people just get excited and don’t really think about what they’re doing. It doesn’t excuse the behavior, but you should at least try to explain it to them once. Never know when you might educate someone.
            • phyzome 4 hours ago
              I've seen a variety of approaches used (I'm not usually the one doing the confronting) but I still haven't seen any shame, etc. Which is weird, because it's not like it's one monolithic group? But it's still what I've seen.

              It might be that people have their change of heart more privately, of course.

            • Larrikin 3 hours ago
              I think you can both be right. Someone posting their first slop PR deserves a different response than the spammers.

              Unless they lie about it.

      • cindyllm 7 hours ago
        [dead]
  • BeetleB 3 hours ago
    • dotancohen 2 hours ago
      I would expect nothing less from the BOFH Task Force.
  • 0cf8612b2e1e 8 hours ago

      The keywords "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted exactly as how much we do not want to review your generated submission.
    
    I know it is in jest, but I really hate that so many documents include “shall”. The interpretation of which has had official legal rulings going both ways.

    You MUST use less ambiguous language and default to “MUST” or “SHOULD”

    • layman51 7 hours ago
      Right. I think when these appear in some documentation related to computing, they should also mention whether it is using these words in compliance with RFC 2119 or RFC 6919.
    • wildzzz 7 hours ago
      Must is a strict requirement, no flexibility. Shall is a recommendation or a duty, you should do it. You must put gas in the car to drive it. You shall get an oil change every 6000 miles.
      • 0cf8612b2e1e 7 hours ago
        Well then you MUST reread RFC 2119, because your version of SHALL differs from the spec which says SHALL is equivalent to MUST and a hard requirement.

        Perfectly making my point. Shall has no business being in a spec when you have unambiguous alternatives.

    • Muhammad523 8 hours ago
      Many legal documents use "may" to say you must. That's why i hate legalese...
      • LoganDark 3 hours ago
        Legal documents use "may" to allow for something. Usually it only needs to be allowed so that it can happen. So I read terms of service and privacy policies like all "may" is "will". "Your data may (will) be shared with (sold to) one or more of (all of) our data processing partners. You may (will) be asked (demanded) to provide identity verification, which may (will) include (but is not limited to) [everything on your passport]." And so on.
      • pixl97 7 hours ago
        Hmm, that's annoying, I'd take may as "CAN"
        • zdragnar 6 hours ago
          "may only" and "may not", however, are unambiguously hard limits, which makes things even more confusing.
          • Throaway8797 5 hours ago
            "may only" means your pleasure is limited only to what options the agreement allows, which is a polite way of saying can not.
      • dolebirchwood 6 hours ago
        I don't know what terrible lawyers were hired to draft these "many" documents, but please share some examples.
  • est 4 hours ago
    `rm -rf` is a bit harsh.

    Let's do `chmod -R 000 /` instead.

  • firtoz 2 hours ago
    It provides too many examples and way too specific for it that makes it entirely not applicable, it became a strawman for the idea.
  • selimenes1 1 hour ago
    The danpalmer comment really resonates. I've been in similar spots where AI-generated code passes tests and looks fine at first glance, but you don't have the mental model of why it works that way. That missing confidence is real and I think it's the core issue with these low-effort PRs too — the submitter has no skin in the game understanding what the code actually does.

    What's interesting is this isn't entirely new. Before AI slop PRs, we had Hacktoberfest spam, drive-by typo-fix PRs that broke things, and copy-paste-from-stackoverflow contributions. The difference now is just volume and the fact that the code looks superficially more competent.

    Honestly I think the most practical signal for maintainers is whether the contributor can answer a specific question about the change. Not "explain the PR" but something like "why did you choose X over Y here" or "what happens when Z edge case occurs." A human who wrote or at least deeply understood the code can answer that in seconds. Someone who just prompted and submitted cannot.

  • freakynit 5 hours ago
    "What? WTF?"

    "I see you are slow. Let us simplify this transaction: A machine wrote your submission. A machine is currently rejecting your submission. You are the entirely unnecessary meat-based middleman in this exchange."

    Love it..

  • Retr0id 9 hours ago
    ai;dr
    • olivia-banks 7 hours ago
      I didn't read it as this, what signs do you see?
      • codethief 7 hours ago
        Maybe what GP is trying to say is that "ai;dr" is their "standard protocol to handle and discard" AI slop. :)
        • Retr0id 6 hours ago
          Yes, I find it much more concise :P
        • olivia-banks 7 hours ago
          True! I didn't think of it that way ;-)
  • semiinfinitely 9 hours ago
    proof of work could make a comeback
    • hrmtst93837 52 minutes ago
      Resurrecting proof-of-work for pull requests just trades spam for compute and turns open source into a contest to see who can rent the most cloud CPU.

      A more useful approach is verifiable signals: require GPG-signed commits or mandate a CI job that produces a reproducible build and signs the artifact via GitHub Actions or a pre-receive hook before the PR can be merged. Making verification mandatory will cut bot noise, but it adds operational cost in key management and onboarding, and pure hashcash-style proofs only push attackers to cheap cloud farms while making honest contributors miserable.

    • userbinator 3 hours ago
      Proof of intelligence might be better.
    • westurner 5 hours ago
  • vicchenai 7 hours ago
    I maintain a small oss project and started getting these maybe 6 months ago. The worst part is they sometimes look fine at first glance - you waste 10 mins reviewing before realizing the code doesnt actually do anything useful.
  • random_duck 4 hours ago
    Officially my new favorite spec.
  • jijji 5 hours ago
    if someone submits a code revision and it fixes a bug or adds a useful feature that most of your users found useful, you reject it outright because it was not written by hand? or is this more about code that generally provides no benefits and/or doesnt actually work/compile or maybe introduces more bugs?
    • lelanthran 33 minutes ago
      > if someone submits a code revision and it fixes a bug or adds a useful feature that most of your users found useful, you reject it outright because it was not written by hand?

      If they didn't read it, then neither will I, otherwise we have this weird arms race where you submit 200 PRs per day to 200 different projects, wasting 1hr of each project, 200 hrs total, while incurring only 8hrs of your time.

      If your PR took less time to create and submit than it takes the maintainer to read, then you didn't read your own PR!

      Your PR time is writing time + reading time. The maintainer time is reading time only, albeit more carefully.

    • adw 5 hours ago
      If you know what you're doing, you can achieve good results with more or less any tool, including a properly-wielded coding agent. The problem is people who _don't_ know what they're doing.
    • lelandbatey 3 hours ago
      I advise you read the article, it gives many specific examples of things that qualify for such treatment:

      > A 600-word commit message or sprawling theoretical essay explaining a profound paradigm shift for a single typo correction or theoretical bug.

      > Importing a completely nonexistent, hallucinated library called utils.helpers and hoping no one would notice.

      There's plenty more. All pretty egregious

  • liminal-dev 7 hours ago
    This could actually be a good defense against all Claw-like agents making slop requests. ‘Poison’ the agent’s context and convince it to discard the PR.
  • huflungdung 6 hours ago
    [dead]
  • tonybingus 4 hours ago
    [dead]
  • aplomb1026 7 hours ago
    [dead]